CodeReview

GOAL:

To be able to identify any violations of
the Java coding standards and documentation.

Reviewer: Mari-Lee Flestado
Reviewee: Jeho Jung

File 
Lines 
Violation 
Comments
MyRuler.java
1, 2,3, *
EJS-5
Code is indented 4 spaces instead of 2 spaces
MyRuler.java
1 ,3
EJS-SE-JAVA-2
Code used the wildcard "*" in import statement 
MyRuler.java

121,147 
EJS-22
Code did not use lowercase for the first word for method names.
MyRuler.java
7, 156
EJS-46


Code did not use a fixed ordering for Javadoc tags.



The logic of the code itself performs the task in a very efficient 
manner. I did run the code also and what I really like about it is 
how the knights captured the castle really fast and when the 
knights captured the opponent's castle then it can create more
knights and peasants. That was one of the strategy that I tried 
to implement in my own code but it didn't really work. 
However, the only thing that I've notice was the lack of good 
application of Java coding documentations which I have listed
above. But other than that he implemented a very interesting 
strategy in his program.